Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

[REVIEW_ONLY] Splitview #8522

Closed
wants to merge 280 commits into from
Closed

[REVIEW_ONLY] Splitview #8522

wants to merge 280 commits into from

Conversation

JeffryBooher
Copy link
Contributor

  • This pr creates a split view of either side-by-side or upper-lower views of 2 different files.
  • From the View Menu select "Split Vertically" or "Split Horizontally" to create a second pane.
  • Selecting the menu item again will collapse the panes down to a single pane (merging the two working sets and showing the current view)
  • Selecting the opposing menu item will just reorient the views without disturbing the documents
  • A blue outline currently denotes the active pane. Functions such as opening a document, searching, etc... will target the active pane. Functions like Close All will target both panes and close all documents.
  • Lint will work on the currently focused editor
  • Images are not supported and viewing images has been disabled in this build
  • The UI as it works now is temporary. A UI treatment story will come next with @larz0 UI treatments

Known Issue:
#8513 (comment)
The selection is getting reworked with @larz0 UI treatment and will be addressed at that time

I encourage anyone who has cycles to test this. Obviously this is a big change and needs quite a number of eyes on it.

…File, move traversal code to mainViewManager
…document was opened to maintain backwards compatability
@JeffryBooher
Copy link
Contributor Author

Closing in lieu of #8913

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants